=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= <tigbrc...@protonmail.com>, =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= <tigbrc...@protonmail.com> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/89...@github.com>
================ ---------------- tigbr wrote: A @isuckatcs specifically requested [testing C and Objective-C or specifying in the check that those languages are not supported](https://github.com/llvm/llvm-project/pull/89925#discussion_r1578557769). > The default config is `-std=c++11-or-later`, but this check is not limited to > that only, so we want to run it with `-std=c++98-or-later`. > > The check also supports C and Objective-C, so please add `.c` and `.m` test > files and create tests for those languages too. > > If you don't want to support any of these languages, please add `bool > isLanguageVersionSupported(const LangOptions &LangOpts) const override;` to > your check and configure the supported languages. C-style tagged unions are supported in Objective-C and Objective-C++ so why exclude these languages? If we support them, then they should be tested. https://github.com/llvm/llvm-project/pull/89925 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
