=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= <tigbrc...@protonmail.com>, =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= <tigbrc...@protonmail.com> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/89...@github.com>
================ @@ -0,0 +1,182 @@ +//===--- TaggedUnionMemberCountCheck.cpp - clang-tidy ---------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "TaggedUnionMemberCountCheck.h" +#include "../utils/OptionsUtils.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "llvm/ADT/STLExtras.h" +#include "llvm/ADT/SmallSet.h" + +using namespace clang::ast_matchers; + +namespace clang::tidy::bugprone { + +TaggedUnionMemberCountCheck::TaggedUnionMemberCountCheck( + StringRef Name, ClangTidyContext *Context) + : ClangTidyCheck(Name, Context), + StrictModeIsEnabled(Options.get(StrictModeIsEnabledOptionName, true)), + CountingEnumHeuristicIsEnabled( + Options.get(CountingEnumHeuristicIsEnabledOptionName, true)), + RawCountingEnumPrefixes(Options.get(CountingEnumPrefixesOptionName, "")), + RawCountingEnumSuffixes( + Options.get(CountingEnumSuffixesOptionName, "count")), + ParsedCountingEnumPrefixes( + utils::options::parseStringList(RawCountingEnumPrefixes)), + ParsedCountingEnumSuffixes( + utils::options::parseStringList(RawCountingEnumSuffixes)) {} + +void TaggedUnionMemberCountCheck::storeOptions( + ClangTidyOptions::OptionMap &Opts) { + Options.store(Opts, StrictModeIsEnabledOptionName, StrictModeIsEnabled); + Options.store(Opts, CountingEnumHeuristicIsEnabledOptionName, + CountingEnumHeuristicIsEnabled); + Options.store(Opts, CountingEnumPrefixesOptionName, RawCountingEnumPrefixes); + Options.store(Opts, CountingEnumSuffixesOptionName, RawCountingEnumSuffixes); +} + +void TaggedUnionMemberCountCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + recordDecl( + allOf(anyOf(isStruct(), isClass()), ---------------- 5chmidti wrote: All arguments passed to `recordDecl` are already behaving as if they were passed to an `allOf` matcher, so you can remove the `allOf`. `recordDecl(foo(), bar())` has the same meaning as `recordDecl(allOf(foo(), bar()))` https://github.com/llvm/llvm-project/pull/89925 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
