[clang] [Serialization] No transitive identifier change (PR #92085)

[Chuanqi Xu via cfe-commits]

================
@@ -3896,7 +3903,7 @@ void ASTWriter::WriteIdentifierTable(Preprocessor &PP,
 
       // Write out identifiers if either the ID is local or the identifier has
       // changed since it was loaded.
-      if (ID >= FirstIdentID || !Chain || !II->isFromAST() ||
+      if (isLocalIdentifierID(ID) || !Chain || !II->isFromAST() ||
----------------
ChuanqiXu9 wrote:

Nice catch! The  `!II->isFromAST()` check looks redundant indeed. I've made a 
NFC patch to address this:  
https://github.com/llvm/llvm-project/commit/799ae77993fa5d7b0638f10b3895090f8748de92

https://github.com/llvm/llvm-project/pull/92085
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits