================
@@ -3896,7 +3903,7 @@ void ASTWriter::WriteIdentifierTable(Preprocessor &PP,
// Write out identifiers if either the ID is local or the identifier has
// changed since it was loaded.
- if (ID >= FirstIdentID || !Chain || !II->isFromAST() ||
+ if (isLocalIdentifierID(ID) || !Chain || !II->isFromAST() ||
----------------
jansvoboda11 wrote:
Ah, got it. I was looking at this line in `ASTWriter.h`:
```c++
/// The first ID number we can use for our own identifiers.
serialization::IdentID FirstIdentID = serialization::NUM_PREDEF_IDENT_IDS;
```
and didn't realize it's being re-initialized in
`ASTWriter::ReaderInitialized()`.
Doesn't that make the `!II->isFromAST()` check redundant then?
https://github.com/llvm/llvm-project/pull/92085
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
