dwblaikie wrote: Commit without precommit review is fine, especially from a code owner - if you only wanted the PR for automated precommit checking, you can add the `skip-precommit-approval` to indicate that the PR isn't intended for precommit review. But, yeah, otherwise it's good that if something /is/ sent for review, that it's not committed until it is reviewed. (code owners/domain experts sometimes get into the niche where this gets a bit fuzzy and it's "here's an idea I had, anyone got better ones/thoughts on this, otherwise I'll go ahead with it" - but yeah, usually the simplest way to deal with that is to have someone else you were asking say "yeah, sounds OK, I don't have any particularly better ideas about how to do this", etc)
https://github.com/llvm/llvm-project/pull/80371 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
