tahonermann accepted this revision. tahonermann added a comment. This revision is now accepted and ready to land.
This looks good to me modulo a couple of nits. ================ Comment at: clang/include/clang/Lex/Lexer.h:806-807 /// Try to consume an identifier character encoded in UTF-8. /// \param CurPtr Points to the start of the (potential) UTF-8 code unit /// sequence. On success, updated to point past the end of it. /// \return \c true if a UTF-8 sequence mapping to an acceptable identifier ---------------- `Tok` should be documented here. ================ Comment at: clang/lib/Lex/Lexer.cpp:1800 + // calling ConsumeChar ensures the NeedsCleaning flag is set on the token + // being lexed, and that warnings about trailing spaces are emmitted. + ConsumeChar(CurPtr, FirstCodeUnitSize, Tok); ---------------- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D159345/new/ https://reviews.llvm.org/D159345 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
