efriedma added a comment.
This seems to be close to a good state.
================
Comment at: clang/lib/AST/Expr.cpp:3444
if (CE->getCastKind() == CK_NoOp ||
CE->getCastKind() == CK_LValueToRValue ||
CE->getCastKind() == CK_ToUnion ||
----------------
An CK_LValueToRValue conversion needs to change IsForRef (or else you're
checking whether the address of the value is constant, not the value itself).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D151587/new/
https://reviews.llvm.org/D151587
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
