tomasz-kaminski-sonarsource added inline comments.

================
Comment at: clang/lib/Analysis/CFG.cpp:1936-1938
+    for (LocalScope::const_iterator I = DstPos; I != BasePos; ++I)
+      if (I.pointsToFirstDeclaredVar())
+        appendScopeBegin(Block, *I, S);
----------------
steakhal wrote:
> Probably, we could also use a `llvm::make_range(DstPos, BasePos)` here, but 
> I'm not sure if that's more readable or not.
We need to call iterator member function `I` here, so we cannot replace it with 
the range.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D153273/new/

https://reviews.llvm.org/D153273

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to