cor3ntin added inline comments.
================
Comment at: clang/include/clang/Sema/Lookup.h:228-229
Other.Paths = nullptr;
- Other.Diagnose = false;
+ Other.DiagnoseAccess = false;
+ Other.DiagnoseAmbiguous = false;
return *this;
----------------
rsmith wrote:
> cor3ntin wrote:
> > Does anything break if you remove these two lines? they don't appear useful
> I think these make sense: if we move a lookup result into this one, then the
> other lookup result shouldn't issue diagnostics any more. (Otherwise we could
> see the same diagnostics twice.)
The reason I'm asking is that we don't seem consistent about resetting the
state of the moved-from lookup, so i don;t know if moved from lookup are ever
reused. and if they are, should we use std::exchange or something along those
lines?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D155387/new/
https://reviews.llvm.org/D155387
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
