shafik added a comment.

It looks like the paragraphs in `class.member.lookup` have changed a lot and so 
the tests don't totally match in that directory. Fixing that seems like a big 
piece of work but maybe worth doing.



================
Comment at: clang/include/clang/Sema/Lookup.h:152
+        DiagnoseAccess(Redecl == Sema::NotForRedeclaration),
+        DiagnoseAmbiguous(Redecl == Sema::NotForRedeclaration) {
     configure();
----------------
Note sure about this, alternatively I could set it to what `DiagnoseAccess` is 
set to as well.


================
Comment at: clang/lib/Sema/SemaOverload.cpp:14930
   LookupQualifiedName(R, Record->getDecl());
-  R.suppressDiagnostics();
+  R.suppressAccessDiagnostics();
 
----------------
I was a bit conservative where I changed this but maybe we should do this 
everywhere.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D155387/new/

https://reviews.llvm.org/D155387

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to