MaskRay added a comment. In D153008#4428694 <https://reviews.llvm.org/D153008#4428694>, @abel-bernabeu wrote:
> In D153008#4428568 <https://reviews.llvm.org/D153008#4428568>, @MaskRay wrote: > >> This new update still applies many unneeded `getParser().Lex();` and adds a >> test at a wrong layer >> <https://maskray.me/blog/2021-08-08-toolchain-testing#the-test-checks-at-the-wrong-layer> >> (clang/test/CodeGen): > > Would you rather have: > > - LLVM IR as input > - assembly as output > - the test placed under llvm/test/CodeGen/RISCV/ > > ? > > That would make the test more verbose, but it would reduce the testing scope. > Please confirm your preference. I created D153204 <https://reviews.llvm.org/D153204> as an alternative. Thanks for reporting the issue! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D153008/new/ https://reviews.llvm.org/D153008 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
