asb accepted this revision. asb added a comment. In D146463#4255927 <https://reviews.llvm.org/D146463#4255927>, @paulkirth wrote:
> @asb Are we happy with the state of consensus w.r.t. using `x3`? I think the > lingering concerns from the psABI discussion have been resolved. Yes, all LGTM now. ================ Comment at: clang/lib/Driver/ToolChains/Clang.cpp:2062 const llvm::Triple &Triple = TC.getTriple(); - // Default small data limitation is eight. - const char *SmallDataLimit = "8"; + // Default small data limitation on some platforms(Android and Fuchsia) is + // zero, otherwise its eight. ---------------- Nit: Missing space after platforms Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146463/new/ https://reviews.llvm.org/D146463 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
