MyDeveloperDay added subscribers: sammccall, klimek. MyDeveloperDay added a comment.
In D147176#4231952 <https://reviews.llvm.org/D147176#4231952>, @rymiel wrote: >> didn't go via the normal clang-format reviewers > > Is there a reason for this? This isn't the only case either, for example: > https://reviews.llvm.org/D143070 https://reviews.llvm.org/D144170 > https://reviews.llvm.org/D88299 https://reviews.llvm.org/D135356 > > I don't have a lot of experience here, so maybe I'm missing "historical" > context, but this confuses me a lot... @klimek was one of the original clang-format creators, and @sammccall I believe works on clangd among many other things, which might well be consuming libFormat. Honestly these developers are pretty much 'OGs' , I'm happy to tidy up after them if they don't quite follow our current conventions. Obviously at any point you can add yourself to a review and add the appropriate tags. Phabractor does support automatically assigned code reviewers via the "Owners" package, and via Herald rules. I could see if I can add one to at least auto assign the clang-format tag, that should bring it onto our radar Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147176/new/ https://reviews.llvm.org/D147176 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
