Ayal added inline comments.
================
Comment at: clang/test/SemaOpenCL/invalid-kernel-parameters.cl:90
+#if __OPENCL_C_VERSION__ <= CL_VERSION_1_2
typedef struct FooImage2D // expected-note{{within field of type 'FooImage2D'
declared here}}
----------------
yaxunl wrote:
> we should not limit the tests to CL1.2. We should test them with 2.0 to make
> sure there is no diagnostics.
>
> To differentiate between 1.2 and 2.0 you can use -verify=ocl12 and
> -verify=ocl20.
>
> same as below
Using -verify=ocl12 and -verify=ocl20 should probably be done separately as an
NFC patch as it involves many changes IIUC.
The expect's were placed under #ifdef instead (and only them), following e.g.
existing lines 8-12.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D143849/new/
https://reviews.llvm.org/D143849
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
