rmaz added a comment.

In D142780#4087270 <https://reviews.llvm.org/D142780#4087270>, @benlangmuir 
wrote:

> If compiling a single pcm accesses multiple hard links with the same UID, 
> then it would not be possible to use the set of UIDs to get the "right path". 
>  At best we could make it get a deterministic path -- e.g. if we tracked the 
> order of access.

With you so far. Is there a reason we need to use the UIDs in this case? Would 
it be possible to refactor `GetUniqueIDMapping` to instead populate an array 
with all the `FileEntryRef`s that had been seen and serialize that instead?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142780/new/

https://reviews.llvm.org/D142780

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to