rmaz added a comment.

In D142780#4087236 <https://reviews.llvm.org/D142780#4087236>, @benlangmuir 
wrote:

> I think if we want to change this to FileEntryRef it needs to be 
> deterministic which ref you get.

I think this might be the root of the problem we are seeing: depending on build 
configuration sometimes our build inputs are hard links that in the case of 
identical inputs point to the same inode. In that case we are seeing 
non-deterministic header paths serialized in pcm files. IIUC the header files 
are serialized based in their unique ID, so it wouldn't be possible to handle 
this case, is this right?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D142780/new/

https://reviews.llvm.org/D142780

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to