ChuanqiXu marked an inline comment as done.
ChuanqiXu added inline comments.


================
Comment at: clang/lib/Driver/Driver.cpp:5736
+      C.getArgs().hasArg(options::OPT_fmodule_output) &&
+      C.getArgs().hasArg(options::OPT_o)) {
+    SmallString<128> OutputPath;
----------------
dblaikie wrote:
> Is there some way we can avoid this (`-fmodule-output  -o ...`) being a 
> special case? It'd be good if we could use a single common implementation 
> regardless of whether `-o` is used (ie: Figure out the output file name 
> (whether it's implicitly determined by clang, in the absence of `-o`, or 
> explicitly provided by the user through `-o`) and then replace the suffix 
> with `pcm`)?
I guess we can't do it or we can't do it easily. Otherwise the .pcm file will 
always lives in the same directory with the input file.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D137058/new/

https://reviews.llvm.org/D137058

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to