dblaikie added inline comments.
================
Comment at: clang/lib/Driver/Driver.cpp:5733-5735
+ if (!AtTopLevel && isa<PrecompileJobAction>(JA) &&
+ JA.getType() == types::TY_ModuleFile &&
+ C.getArgs().hasArg(options::OPT_fmodule_output) &&
----------------
These conditions might be shared with the previous condition that tests the
opposite?
================
Comment at: clang/lib/Driver/Driver.cpp:5736
+ C.getArgs().hasArg(options::OPT_fmodule_output) &&
+ C.getArgs().hasArg(options::OPT_o)) {
+ SmallString<128> OutputPath;
----------------
Is there some way we can avoid this (`-fmodule-output -o ...`) being a special
case? It'd be good if we could use a single common implementation regardless of
whether `-o` is used (ie: Figure out the output file name (whether it's
implicitly determined by clang, in the absence of `-o`, or explicitly provided
by the user through `-o`) and then replace the suffix with `pcm`)?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D137058/new/
https://reviews.llvm.org/D137058
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
