arsenm added inline comments.
================
Comment at: clang/lib/Sema/SemaChecking.cpp:2674
+
+ if (MagnitudeTy.getCanonicalType() != SignTy.getCanonicalType()) {
+ return Diag(Sign.get()->getBeginLoc(),
----------------
erichkeane wrote:
> arsenm wrote:
> > erichkeane wrote:
> > > curleys not used for single-statement if-statement bodies.
> > It covers 3 lines, it should have braces
> Our standard says 'statments' not 'lines'. This is a single statement.
>
> https://llvm.org/docs/CodingStandards.html#don-t-use-braces-on-simple-single-statement-bodies-of-if-else-loop-statements
Also says 'Similarly, braces should be used when a single-statement body is
complex enough that it becomes difficult to see where the block containing the
following statement began.'
Which is any case where it covers multiple lines
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D140639/new/
https://reviews.llvm.org/D140639
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
