jhuber6 added inline comments.
================
Comment at: clang/tools/clang-linker-wrapper/ClangLinkerWrapper.cpp:1211-1212
+ llvm::sort(Input, [](OffloadingImage &A, OffloadingImage &B) {
+ return A.StringData["triple"].compare(B.StringData["triple"]) == 1 ||
+ A.StringData["arch"].compare(B.StringData["arch"]) == 1;
+ });
----------------
yaxunl wrote:
> should we also sort for offload kind? In the future, we may have both openmp
> and hip binaries embeded.
Sure, this is used to get a deterministic order so we should make sure that
those types line up.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D136701/new/
https://reviews.llvm.org/D136701
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
