ymandel marked 6 inline comments as done.
ymandel added inline comments.
================
Comment at:
clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:527-528
+ auto *Prop2 = Val2.getProperty("has_value");
+ return Prop1 == Prop2 || (Prop1 != nullptr && Prop2 != nullptr &&
+ isTop(*Prop1) && isTop(*Prop2));
}
----------------
xazax.hun wrote:
> ymandel wrote:
> > xazax.hun wrote:
> > > I feel like this logic is repeated multiple times. I wonder if we should
> > > define an `operator==` for `const BoolValue*`.
> > Agreed. I want to wait until we settle on the representation and then we
> > can consider this operator. But, if we end up with a singleton Top then I
> > think we can hold off.
> We ended up not going with a singleton Top, let's reconsider the overloaded
> operator.
added FIXME.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135397/new/
https://reviews.llvm.org/D135397
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
