xazax.hun added inline comments.
================
Comment at:
clang/unittests/Analysis/FlowSensitive/TypeErasedDataflowAnalysisTest.cpp:1192
+ const Environment &Env1, const Value &Val2,
+ const Environment &Env2) final {
+ // Changes to a sounds approximation, which allows us to test whether we
can
----------------
ymandel wrote:
> xazax.hun wrote:
> > Nit: I usually prefer marking whole classes final rather than individual
> > virtual methods, but feel free to leave as is.
> Good point. I was following what's done elsewhere in the file -- I think we
> should update all or nothing. that said, if you mark the class final, then
> what do you do with each method? nothing or `override`?
I prefer override on the methods in that scenario. But I agree that refactoring
changes like this might be better done in a separate NFC commit.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D135397/new/
https://reviews.llvm.org/D135397
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
