AaronLiu added a comment. In D131465#3780767 <https://reviews.llvm.org/D131465#3780767>, @aaron.ballman wrote:
> In D131465#3780717 <https://reviews.llvm.org/D131465#3780717>, @AaronLiu > wrote: > >> This cause a large amount failures in our testing with errors such as: >> >> error: ISO C++17 does not allow 'register' storage class specifier >> [-Wregister] >> >> error: ISO C++17 does not allow dynamic exception specifications >> [-Wdynamic-exception-spec] > > Sorry to hear that. Who is "our" in this case and do you have a suggestion > for how you'd like to proceed? Some down stream regression tests. I see the above comments: > I've reverted this change because it causes major llvm-test-suite breakage. Probably currently this is the best way. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131465/new/ https://reviews.llvm.org/D131465 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
