Author: Fangrui Song Date: 2022-09-03T10:57:29-07:00 New Revision: 89df4e4825ee6136bebbe5f70de29eb80456aaa4
URL: https://github.com/llvm/llvm-project/commit/89df4e4825ee6136bebbe5f70de29eb80456aaa4 DIFF: https://github.com/llvm/llvm-project/commit/89df4e4825ee6136bebbe5f70de29eb80456aaa4.diff LOG: [Driver] Remove unused -Ttext -Tdata -Tbss They lead to -Wunused-command-line-argument and should be written as -Ttext= instead, but the driver options end with a space. -Ttext=0 can be accepted by the JoinedOrSeparate -T, so the JoinedOrSeparate -Ttext/etc are unneeded. Added: Modified: clang/include/clang/Driver/Options.td clang/test/Driver/hexagon-toolchain-elf.c Removed: ################################################################################ diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index d03336f32b968..c7c34f072ba23 100644 --- a/clang/include/clang/Driver/Options.td +++ b/clang/include/clang/Driver/Options.td @@ -764,12 +764,6 @@ def R_Joined : Joined<["-"], "R">, Group<R_Group>, Flags<[CC1Option, CoreOption] MetaVarName<"<remark>">, HelpText<"Enable the specified remark">; def S : Flag<["-"], "S">, Flags<[NoXarchOption,CC1Option,FlangOption,FC1Option]>, Group<Action_Group>, HelpText<"Only run preprocess and compilation steps">; -def Tbss : JoinedOrSeparate<["-"], "Tbss">, Group<T_Group>, - MetaVarName<"<addr>">, HelpText<"Set starting address of BSS to <addr>">; -def Tdata : JoinedOrSeparate<["-"], "Tdata">, Group<T_Group>, - MetaVarName<"<addr>">, HelpText<"Set starting address of DATA to <addr>">; -def Ttext : JoinedOrSeparate<["-"], "Ttext">, Group<T_Group>, - MetaVarName<"<addr>">, HelpText<"Set starting address of TEXT to <addr>">; def T : JoinedOrSeparate<["-"], "T">, Group<T_Group>, MetaVarName<"<script>">, HelpText<"Specify <script> as linker script">; def U : JoinedOrSeparate<["-"], "U">, Group<Preprocessor_Group>, diff --git a/clang/test/Driver/hexagon-toolchain-elf.c b/clang/test/Driver/hexagon-toolchain-elf.c index 3ae2b56de22fd..51132ffce02bd 100644 --- a/clang/test/Driver/hexagon-toolchain-elf.c +++ b/clang/test/Driver/hexagon-toolchain-elf.c @@ -431,7 +431,6 @@ // RUN: -ccc-install-dir %S/Inputs/hexagon_tree/Tools/bin \ // RUN: -mcpu=hexagonv60 \ // RUN: -s \ -// RUN: -Tbss 0xdead -Tdata 0xbeef -Ttext 0xcafe \ // RUN: -t \ // RUN: -e start_here \ // RUN: -uFoo -undefined Bar \ @@ -445,7 +444,6 @@ // CHECK03B: "-L{{.*}}/Inputs/hexagon_tree/Tools/bin/../target/hexagon/lib/v60" // CHECK03B: "-L{{.*}}/Inputs/hexagon_tree/Tools/bin/../target/hexagon/lib" // CHECK03B: "-s" -// CHECK03B: "-Tbss" "0xdead" "-Tdata" "0xbeef" "-Ttext" "0xcafe" // CHECK03B: "-t" // CHECK03B: "-u" "Foo" "-undefined" "Bar" // CHECK03B: "{{[^"]+}}.o" _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
