Author: Fangrui Song Date: 2022-09-03T10:45:30-07:00 New Revision: a2ef7654ec2e907f84a876b1cf5d37fc87754de7
URL: https://github.com/llvm/llvm-project/commit/a2ef7654ec2e907f84a876b1cf5d37fc87754de7 DIFF: https://github.com/llvm/llvm-project/commit/a2ef7654ec2e907f84a876b1cf5d37fc87754de7.diff LOG: [Driver] Change some cc1 only JoinedOrSeparate long options to Separate They are error-prone as they do not end with `=`. Note: for driver -isystem/etc, we have to support the Joined form. Added: Modified: clang/include/clang/Driver/Options.td Removed: ################################################################################ diff --git a/clang/include/clang/Driver/Options.td b/clang/include/clang/Driver/Options.td index a3134fdae87cd..d03336f32b968 100644 --- a/clang/include/clang/Driver/Options.td +++ b/clang/include/clang/Driver/Options.td @@ -4275,7 +4275,7 @@ def : Flag<["-"], "integrated-as">, Alias<fintegrated_as>, Flags<[NoXarchOption] def : Flag<["-"], "no-integrated-as">, Alias<fno_integrated_as>, Flags<[CC1Option, FlangOption, NoXarchOption]>; -def working_directory : JoinedOrSeparate<["-"], "working-directory">, Flags<[CC1Option]>, +def working_directory : Separate<["-"], "working-directory">, Flags<[CC1Option]>, HelpText<"Resolve file paths relative to the specified directory">, MarshallingInfoString<FileSystemOpts<"WorkingDir">>; def working_directory_EQ : Joined<["-"], "working-directory=">, Flags<[CC1Option]>, @@ -6204,20 +6204,20 @@ def fmodules_strict_context_hash : Flag<["-"], "fmodules-strict-context-hash">, HelpText<"Enable hashing of all compiler options that could impact the " "semantics of a module in an implicit build">, MarshallingInfoFlag<HeaderSearchOpts<"ModulesStrictContextHash">>; -def c_isystem : JoinedOrSeparate<["-"], "c-isystem">, MetaVarName<"<directory>">, +def c_isystem : Separate<["-"], "c-isystem">, MetaVarName<"<directory>">, HelpText<"Add directory to the C SYSTEM include search path">; -def objc_isystem : JoinedOrSeparate<["-"], "objc-isystem">, +def objc_isystem : Separate<["-"], "objc-isystem">, MetaVarName<"<directory>">, HelpText<"Add directory to the ObjC SYSTEM include search path">; -def objcxx_isystem : JoinedOrSeparate<["-"], "objcxx-isystem">, +def objcxx_isystem : Separate<["-"], "objcxx-isystem">, MetaVarName<"<directory>">, HelpText<"Add directory to the ObjC++ SYSTEM include search path">; -def internal_isystem : JoinedOrSeparate<["-"], "internal-isystem">, +def internal_isystem : Separate<["-"], "internal-isystem">, MetaVarName<"<directory>">, HelpText<"Add directory to the internal system include search path; these " "are assumed to not be user-provided and are used to model system " "and standard headers' paths.">; -def internal_externc_isystem : JoinedOrSeparate<["-"], "internal-externc-isystem">, +def internal_externc_isystem : Separate<["-"], "internal-externc-isystem">, MetaVarName<"<directory>">, HelpText<"Add directory to the internal system include search path with " "implicit extern \"C\" semantics; these are assumed to not be " _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits