yihanaa added a comment. In D131979#3753706 <https://reviews.llvm.org/D131979#3753706>, @yihanaa wrote:
> Keep same behavior with current clang, don't emit an error when 1st arg is > volatile qualified. > > Ignore the implicit cast from user-written-type to 'const void *' on the 1st > arg, because CodeGen need user-written-type to generate correct > TypeDescriptor (this class in compiler-rt/UBSan), then, clang will emit cast > instruction which cast type from user-written-type to VoidPtr in CodeGen. > > But I still have some questions, for example: if someone pass a array > type(e.g. char[1]) as the 1st arg, what should the correct TypeDescriptor? > char[1] OR char *, clang will generate char * in this patch, you are experts > and what do you all think? Hi John, can you please look at here, this is current version of patch's comment, and probably folded by Phabricator because of too many comments. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131979/new/ https://reviews.llvm.org/D131979 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
