benlangmuir added inline comments.
================
Comment at:
clang/include/clang/Tooling/DependencyScanning/ModuleDepCollector.h:204
+ /// invocation, for example when there are multiple chained invocations.
+ void handleInvocation(CompilerInvocation CI);
+
----------------
jansvoboda11 wrote:
> Nit: `handle*()` functions are associated with `DependencyConsumer` in my
> brain. Could we find a distinct name to avoid confusion between all the
> different types we're using here?
I split up applying changes to the CI from passing to the consumer. Hopefully
it's a little simpler now.
================
Comment at: clang/test/ClangScanDeps/modules-implicit-dot-private.m:70
// CHECK: "-fmodule-file={{.*}}/FW-{{.*}}.pcm"
+// CHECK: "-fmodule-file={{.*}}/FW_Private-{{.*}}.pcm"
// CHECK: ],
----------------
Calling out this change so it doesn't disappear into the other test changes.
The order changed because in the driver version of this we were appending
-fmodule-file= options in the order of dependencies, but in the new code we
insert into `PrebuiltModuleFiles` which is a `std::map`, so the entries are
alphabetically sorted.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D132405/new/
https://reviews.llvm.org/D132405
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
