aaron.ballman added a comment. In D132324#3742394 <https://reviews.llvm.org/D132324#3742394>, @ldionne wrote:
> Please don't change libc++ things like that without my approval first. This > is a transition I've been working on for 2+ years, I had a local patch for it > waiting to be published, and this patch is incomplete in several ways. I > greatly appreciate the effort and wanting to chime into this transition, > however concretely this was rushed in. FWIW, I was also pretty surprised to see something with `[RFC]` in the title be proposed on a Saturday night and landed the next morning. While we had community agreement on the original deprecation, I think we usually would then follow up with an RFC (on Discourse) proposing to remove the deprecated functionality so people have more notice before the changes landed. (Just something to keep in mind for the future.) For clarity, @ldionne are you requesting that these changes be reverted due to being incomplete, or do you prefer this be fixed forward? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D132324/new/ https://reviews.llvm.org/D132324 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
