MaskRay added a comment.

In D129832#3654040 <https://reviews.llvm.org/D129832#3654040>, @vitalybuka 
wrote:

> problem with included files that  we don't know which non-inlined version of 
> the function will endup in the binary
> so using this option, user may unintentionally disable instrumentation on all 
> included headers, even when included from a different place

This argument applies to vague linkage functions which are deduplicated.
There are many internal linkage function use cases which can benefit this, e.g. 
`static inline`.
But thanks for the comment. Let me improve the summary.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D129832/new/

https://reviews.llvm.org/D129832

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to