rjmccall added a comment. Looks good, thanks! Approved with the rename as discussed.
================ Comment at: clang/include/clang/Basic/LangOptions.h:747 + /// Return difference with the given option set. + FPOptionsOverride diffWith(const FPOptions &Base); + ---------------- sepavloff wrote: > rjmccall wrote: > > Can you make direction more obvious in the method name? `diffFrom` would > > make it clear that the result, applied to the base, yields `this`. > I renamed this method to `getChanges`. I am not sure it becomes better. May > be `getChangesFrom` or `getDiffFrom`? Any suggestion is welcome. Yes, I think just adding `From` would make this clearer, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123952/new/ https://reviews.llvm.org/D123952 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
