sepavloff added inline comments.
================ Comment at: clang/lib/Basic/LangOptions.cpp:214 + OverrideMask |= NAME##Mask; +#include "clang/Basic/FPOptions.def" + return FPOptionsOverride(*this, OverrideMask); ---------------- rjmccall wrote: > Hmm. If we can assume that all of the options are single bits (which this is > doing), then this algorithm is basically `FPOptions::storage_type > OverrideMask = (Value ^ Base.Value);`, which makes this cheap enough to be > defined inline in the header. `FPContractMode`, `ConstRoundingMode`, `SpecifiedExceptionMode` and `FPEvalMethod` occupy more than one bit: https://github.com/llvm/llvm-project/blob/main/clang/include/clang/Basic/FPOptions.def. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D123952/new/ https://reviews.llvm.org/D123952 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
