kstoimenov added inline comments.
================
Comment at: clang/lib/CodeGen/SanitizerMetadata.cpp:48-50
+ GVSanitizerMetadata Meta;
+ if (GV->hasSanitizerMetadata())
+ Meta = GV->getSanitizerMetadata();
----------------
Would it make sense to create two separate functions something like
reportGlobalNew and reportGlobalLegacy to make it more clear which one is
which? Then you code will be something like the one below? You can come up with
better names for functions, I am sure.
```
reportGlobal(...) {
reportGlobalNew(...);
reportGlobalLegacy(...);
}
```
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126929/new/
https://reviews.llvm.org/D126929
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
