probinson added a comment.

In D126224#3532769 <https://reviews.llvm.org/D126224#3532769>, @dblaikie wrote:

> While the string would be deduplicated, the offset in the DIEs (or index in 
> DWARFv5, plus offset in .debug_str_offsets) for each of these strings would 
> not. But perhaps that would still be low-cost enough (if we were getting 
> really fancy, we could bake that string offset/index into the abbreviation - 
> though we probably don't have the infrastructure in LLVM's DWARF emission to 
> do that super easily)

DWARF doesn't have a way to encode a section offset into .debug_abbrev.  Best 
you could do (for v5 and up) is pin the string-literal variable name to 
.debug_str_offsets index 0, which keeps the .debug_info overhead to one byte 
for DW_FORM_strx1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D126224/new/

https://reviews.llvm.org/D126224

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to