mgabka added inline comments.
================
Comment at: clang/test/CodeGen/aarch64-attr-mode-complex.c:11
+// CHECK: define{{.*}} { half, half } @c16_test([2 x half] noundef
[[C16A:%.*]])
+// CHECK-NEXT: entry:
+// CHECK-NEXT: [[C16B:%.*]] = extractvalue [2 x half] [[C16A]], 0
----------------
Hi Jolanta,
I the tests from this file, I don't think these check lines are necessary, if
it was me I would rather check only the type of the argument passed into the
function and also the return type.
If you did it like that you could also remove the -Ofast from the RUN lines, as
it does not have impact on the functionality you are testing here.
================
Comment at: clang/test/Sema/attr-mode.c:40
+typedef _Complex float c16a __attribute((mode(HC)));
+int c16a_test[sizeof(c16a) == 4 ? 1 : -1];
----------------
shouldn't we have here and in the line below : "// expected-no-diagnostics" ?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D126479/new/
https://reviews.llvm.org/D126479
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
