aaron.ballman accepted this revision.
aaron.ballman added a comment.

In D124966#3497781 <https://reviews.llvm.org/D124966#3497781>, @aaronpuchert 
wrote:

> In D124966#3497305 <https://reviews.llvm.org/D124966#3497305>, @aaron.ballman 
> wrote:
>
>> Do we need to update any documentation from this?
>
> I don't think so, we don't really specify what we consider as write and what 
> not. It's more of a heuristic anyway, unless at some point we feel 
> comfortable enough to do D52395 <https://reviews.llvm.org/D52395>.

SGTM, thanks for verifying! Continues to LGTM.



================
Comment at: clang/docs/ReleaseNotes.rst:173
   effect.
 
 - ``-Wmisexpect`` warns when the branch weights collected during profiling
----------------
aaronpuchert wrote:
> Or maybe I should add it here? Not sure why there is a blank line.
Either way is fine -- the blank line is an accident, but it'll go away at some 
point.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124966/new/

https://reviews.llvm.org/D124966

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to