aaronpuchert marked 2 inline comments as done.
aaronpuchert added inline comments.


================
Comment at: clang/lib/Analysis/ThreadSafety.cpp:1994
+      case OO_Equal:
+      case OO_PlusEqual:
+      case OO_MinusEqual:
----------------
aaron.ballman wrote:
> If we're going to be handling these, should we also be handling overloads of 
> `++` and `--`?
Yes, in some sense these are also compound assignment operators despite their 
looks. I'll add them as well.

Sadly streams use `<<` and `>>` instead of `<<=` and `>>=`, and we can't really 
assume the former to write.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D124966/new/

https://reviews.llvm.org/D124966

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to