sdesmalen accepted this revision.
sdesmalen added a comment.
This revision is now accepted and ready to land.

Thanks for this @RosieSumpter. If you remove the 'WIP' and s/SVE/SVE2/ from the 
title and description, I'm happy to accept. The negative tests for the SVE(1) 
intrinsics can be added as a separate patch.



================
Comment at: 
clang/test/Sema/aarch64-sve2-intrinsics/acle_sve2_imm_lane.cpp:151-152
+{
+  // expected-error-re@+1 {{argument value {{[0-9]+}} is outside the valid 
range [0, 1]}}
+  SVE_ACLE_FUNC(svcdot_lane,_s64,,)(svundef_s64(), svundef_s16(), 
svundef_s16(), -1, 0);
+  // expected-error-re@+1 {{argument value {{[0-9]+}} is outside the valid 
range [0, 1]}}
----------------
nit: there is also a svcdot_lane,_s32


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123605/new/

https://reviews.llvm.org/D123605

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to