sammccall added a comment.
In D124262#3471841 <https://reviews.llvm.org/D124262#3471841>, @ishaangandhi
wrote:
> Test case added, re-diffed with `-U9999`, and removed redundant constructor.
> Thanks for the quick feedback, @sammccall!
>
> (I didn't wait for the tests to run locally, I am hoping to use your CI
> systems to do that. It seems like a simple enough of a test that I hope I can
> get it right on the first try.)
Unfortunately it looks like you've created a patch that phabricator can render,
but the precommit CI can't apply (it's using `git apply`).
The usual way to upload is with `arc`, but the output of `git diff -U9999`
should also work.
================
Comment at: clang/unittests/Tooling/CompilationDatabaseTest.cpp:852
+ add("other/random/path.cpp");
+ // Proxies for ".H" files are ".C" files, and not ".cpp files"
+ EXPECT_EQ(getProxy("foo/bar/baz/exact.H"), "foo/bar/baz/exact.C");
----------------
Is this really what you intend to test?
I think our goal here is to treat `.H` and `.C` as C++ rather than C, not to
link them together in some way. If the current file is `foo.H`, then `foo.cpp`
and `foo.C` should be equally compelling candidates, but both beat `foo.c`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D124262/new/
https://reviews.llvm.org/D124262
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
