zixuw added a comment.

The problem is that we are trying to shorten the input file paths in 
`PrepareToExecuteAction`, where the `CompilerInstance` is still primal and 
doesn't even have a `FileManager` that we could use. That makes it hard (if 
possible at all) to reverse lookup headermaps and use the spelled names if we 
failed to find a search path prefix.
The impact is that we won't be able to get an angled include name for cases 
where an input doesn't reside in any of the normal search paths, but a 
headermap entry maps some name to that path. Or we might get the wrong include 
name where there are both headermap entries and search paths that match the 
input path and the ordering matters.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D123831/new/

https://reviews.llvm.org/D123831

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to