MaskRay requested changes to this revision.
MaskRay added inline comments.
This revision now requires changes to proceed.
Herald added a subscriber: StephenFan.


================
Comment at: clang/test/Driver/complex-range-flags.c:3
+
+// REQUIRES: clang-driver
+
----------------
delete

this is legacy which is not needed for a long time


================
Comment at: clang/test/Driver/complex-range-flags.c:6
+// CHECK-FULL-RANGE: "-cc1"
+// CHECK-FULL-RANGE: "-fcx-range=full"
+
----------------
Move CHECK lines below RUN


================
Comment at: clang/test/Driver/complex-range-flags.c:14
+
+// RUN: %clang -### -c %s 2>&1 \
+// RUN:   | FileCheck --check-prefix=CHECK-FULL-RANGE %s
----------------
No need to wrap lines


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119290/new/

https://reviews.llvm.org/D119290

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D119290: [Clan... Zahira Ammarguellat via Phabricator via cfe-commits
    • [PATCH] D119290: ... Fangrui Song via Phabricator via cfe-commits

Reply via email to