yihanaa added a comment. In D122662#3414284 <https://reviews.llvm.org/D122662#3414284>, @erichkeane wrote:
> I'd also suggest splitting into the '3' things that you're trying to > accomplish above. The CGBuiltin.cpp code has way too much going on to > reasonably review. In D122662#3414284 <https://reviews.llvm.org/D122662#3414284>, @erichkeane wrote: > I'd also suggest splitting into the '3' things that you're trying to > accomplish above. The CGBuiltin.cpp code has way too much going on to > reasonably review. Maybe I should split the third thing into another separate patch, the first thing needs to modify the indent when adding constant array support, that is the third thing (modify the indent), what do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122662/new/ https://reviews.llvm.org/D122662 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
