yihanaa added a comment. Thanks for review @erichkeane ,maybe i should split this patch.
================ Comment at: clang/docs/ReleaseNotes.rst:93 and `51641 <https://github.com/llvm/llvm-project/issues/51641>`_. +- The builtin function __builtin_dump_struct would crash clang when the target + struct have bitfield. Now it fixed. ---------------- erichkeane wrote: > What is this from/for? Is this left over from a previous patch? The fixed by me in https://reviews.llvm.org/D122248, this modification appeared in multiple places in ReleaseNote, so I removed the redundant. ================ Comment at: clang/docs/ReleaseNotes.rst:113 ------------------------------------------------- -- The builtin function __builtin_dump_struct would crash clang when the target - struct have bitfield. Now it fixed, and __builtin_dump_struct support dump - the bitwidth of bitfields. - This fixes `Issue 54462 <https://github.com/llvm/llvm-project/issues/54462>`_. +- The builtin function __builtin_dump_struct support dump constant array and the + bitwidth of bitfields in a struct. ---------------- erichkeane wrote: > "now supports dumping constant arrays" perhaps? Yes，i add constant array support int this patch. ================ Comment at: clang/docs/ReleaseNotes.rst:114 +- The builtin function __builtin_dump_struct support dump constant array and the + bitwidth of bitfields in a struct. + ---------------- erichkeane wrote: > This should probably be a different entry than the bitfield one. should i separate the two？ ================ Comment at: clang/docs/ReleaseNotes.rst:155 -- Improve __builtin_dump_struct: - ---------------- erichkeane wrote: > Probably want a separate patch to fix these. Okay Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D122662/new/ https://reviews.llvm.org/D122662 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
