aaron.ballman added a comment. In D120397#3401380 <https://reviews.llvm.org/D120397#3401380>, @ChuanqiXu wrote:
> In D120397#3399808 <https://reviews.llvm.org/D120397#3399808>, @aaron.ballman > wrote: > >> Can you also add a release note that explains we've fixed the crash? > > My thought is to edit a release note standalone. Since there are already many > works in modules now. I guess it might be better to try to give a summarize. SGTM! In D120397#3402081 <https://reviews.llvm.org/D120397#3402081>, @iains wrote: > for the record, I experimented with adding the linkage as an output for AST > dumps (adding to TextNodeDumper / DeclPrinter), since it seems that this > could be generally useful. > this works fine, but, it would create a lot of testsuite churn - around 350 > tests would need amendment, so I've punted on it for now (perhaps unit tests > can always accomplish the same). Yeah, our AST dumping tests are very fragile to changes to the AST dump, unfortunately. It's very reasonable to punt on that, but thank you for looking into it! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120397/new/ https://reviews.llvm.org/D120397 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
