aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
In D120397#3398562 <https://reviews.llvm.org/D120397#3398562>, @ChuanqiXu wrote: > Both `ast-dump` and `ast-dump=json` couldn't solve this. And I feel > `static_assert` is hard to implement. But from your wording, I feel a > unittest could match the intention. @dblaikie @aaron.ballman I thought the > key point here is to test the linkage actually. And I feel the unittest is > really good for this. I like that solution, great idea! The changes LGTM. Can you also add a release note that explains we've fixed the crash? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120397/new/ https://reviews.llvm.org/D120397 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
