bnbarham marked an inline comment as done. bnbarham added inline comments.
================ Comment at: llvm/include/llvm/Support/Error.h:1284 - StringRef getFileName() { return FileName; } + StringRef getFileName() const { return FileName; } ---------------- dexonsmith wrote: > bnbarham wrote: > > Should this be in a change all by itself? > Yes, but I also know you already split this out so I guess you just need to > rebase :). Heh, when you suggested I pull the rename out I basically thought "welll, that answer this question" So yep, it's out and I'll rebase this one :). Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121426/new/ https://reviews.llvm.org/D121426 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits