bnbarham added a comment. In D121426#3376442 <https://reviews.llvm.org/D121426#3376442>, @dexonsmith wrote:
>> Includes two test fixes (since chained mappings are no longer allowed) >> and adds a new test for multiple overlays. > > Are we sure no one needs to support chained mappings? Has there been a > ~~clang-dev~~ discourse discussion about it already? Just concerned that some > vendor might rely on being able to support this. I'm not *positive*, no, but I would be fairly surprised. You could just add the `A -> C` mapping if you really do want it. But I can start up that conversation if you think it needs having. I actually didn't initially realise that there was a test for this case - `vfsroot-with-overlay.c` did test "indirection", but I completely missed it when I was looking through. I *thought* the only case was the one Nathan added in `directory.c` (and in that case what we really wanted was was what's now `fallback`). @vsapsai do you know any clients of the chaining/nesting/indirection? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121426/new/ https://reviews.llvm.org/D121426 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
