craig.topper added inline comments.

================
Comment at: clang/utils/TableGen/RISCVVEmitter.cpp:1321
   ListSeparator LS(" && ");
+  // Full multiplies for EEW=64 require V.
+  if (PredefinedMacros & RISCVPredefinedMacro::V)
----------------
It's not as useful here. Should put it on line 812 where the condition is 
checked and explain that a FullMultiply is MULH and SMUL.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117913/new/

https://reviews.llvm.org/D117913

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to