hokein accepted this revision.
hokein added a comment.
This revision is now accepted and ready to land.
Thanks, this looks great!
================
Comment at: clang-tools-extra/clangd/Selection.cpp:364
+ return *Offset < First;
+ log("Start {0}", Tok.dumpForTests(SM));
+ StartInvalid = true;
----------------
nit: remove this debug code.
================
Comment at: clang-tools-extra/clangd/Selection.cpp:390
+ return *Offset <= Last;
+ log("End {0}", Tok.dumpForTests(SM));
+ EndInvalid = true;
----------------
and here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117107/new/
https://reviews.llvm.org/D117107
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
