sammccall added a comment. PTAL
================ Comment at: clang-tools-extra/clangd/Selection.cpp:350 + return *Offset < First; + StartInvalid = false; + return false; ---------------- sammccall wrote: > hokein wrote: > > this should be `true`. > Oh shoot, now the assert is firing, I must have missed some cases :-( > Need to fix this. OK, this was just not handling EOF token location (which offsetInSelFile rejects, correctly I think) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117107/new/ https://reviews.llvm.org/D117107 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
