kyulee added inline comments.

================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:961
+      DB.finalize();
+    }
+  }
----------------
I think when `-debug-info-correlate` is used without debug info, we should fail 
or emit a warning here instead of silently proceeding it because we cannot 
correlate it anyhow down the road.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114565/new/

https://reviews.llvm.org/D114565

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to